Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor code by removing license header #3333

Merged
merged 14 commits into from
Nov 11, 2023
Merged

fix: Refactor code by removing license header #3333

merged 14 commits into from
Nov 11, 2023

Conversation

wangsizhu0504
Copy link
Member

Associated PR: #3323

The frontend of streampark is based on an open-source frontend project: vue-vben-admin(https://github.com/vbenjs/vue-vben-admin). Some files were directly copied from the source code of vue-vben-admin. These copied files had an Apache License header. However, This does not comply with license requirements. Therefore, we removed the License Header from these copied files and keep the Apache License Header to our own code files. more details are as follows:

  1. The source code of all files in the following files or folders from the vue-vben-admin project.

streampark-console/streampark-console-webapp/build/**
streampark-console/streampark-console-webapp/src/components/**
streampark-console/streampark-console-webapp/src/directives/**
streampark-console/streampark-console-webapp/src/logics/**
streampark-console/streampark-console-webapp/src/utils/**
streampark-console/streampark-console-webapp/src/App.vue
streampark-console/streampark-console-webapp/src/main.ts
streampark-console/streampark-console-webapp/src/locales/helper.ts
streampark-console/streampark-console-webapp/src/locales/setupI18n.ts
streampark-console/streampark-console-webapp/src/locales/useLocale.ts
streampark-console/streampark-console-webapp/src/views/base/error-log/**
streampark-console/streampark-console-webapp/src/views/base/exception/**
streampark-console/streampark-console-webapp/src/views/base/lock/**
streampark-console/streampark-console-webapp/src/views/base/redirect/**
streampark-console/streampark-console-webapp/src/enums/**
streampark-console/streampark-console-webapp/src/design/**
streampark-console/streampark-console-webapp/src/hooks/**
streampark-console/streampark-console-webapp/src/layouts/**
streampark-console/streampark-console-webapp/src/router/**
streampark-console/streampark-console-webapp/src/settings/**
streampark-console/streampark-console-webapp/src/store/**
streampark-console/streampark-console-webapp/types/**

  1. useAttrs The built-in hooks for data in vue3 don't need to be written separately, but need to be removed in this PR (https://vuejs.org/api/sfc-script-setup.html#useslots-useattrs). The affected files are

streampark-console/streampark-console-webapp/src/components/Button/src/BasicButton.vue
streampark-console/streampark-console-webapp/src/components/Button/src/PopConfirmButton.vue
streampark-console/streampark-console-webapp/src/components/Description/src/Description.vue
streampark-console/streampark-console-webapp/src/components/Drawer/src/BasicDrawer.vue
streampark-console/streampark-console-webapp/src/components/Form/src/components/ApiRadioGroup.vue
streampark-console/streampark-console-webapp/src/components/Form/src/components/ApiSelect.vue
streampark-console/streampark-console-webapp/src/components/Form/src/components/RadioButtonGroup.vue
streampark-console/streampark-console-webapp/src/components/Modal/src/components/Modal.tsx

wolfboys
wolfboys previously approved these changes Nov 10, 2023
Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangsizhu0504
Copy link
Member Author

cc @caicancai @wolfboys Changes to the license header in dev-2.1.2 have been synchronized

@caicancai
Copy link
Member

LGTM+1

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit 4788f1d into apache:dev Nov 11, 2023
8 checks passed
@wangsizhu0504 wangsizhu0504 deleted the fix/license branch February 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants