Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fix teamId is null occur an sql error #3362

Closed
wants to merge 1 commit into from

Conversation

minchowang
Copy link
Contributor

What changes were proposed in this pull request

Issue Number: close #3361

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@caicancai
Copy link
Member

Thank you for your contribution

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution, Looking forward to your next contribution。

@wolfboys
Copy link
Member

cc @minchowang The RC branch is a release candidate, It is not recommended to commit to this branch, Can you commit the code to the dev-2.1.2 branch?

@minchowang
Copy link
Contributor Author

cc @minchowang The RC branch is a release candidate, It is not recommended to commit to this branch, Can you commit the code to the dev-2.1.2 branch?

OK, this pr #3365

@wolfboys
Copy link
Member

cc @minchowang The RC branch is a release candidate, It is not recommended to commit to this branch, Can you commit the code to the dev-2.1.2 branch?

OK, this pr #3365

Thanks, Great job! The issue also exists in the dev branch. Can you please submit it to the dev branch again? 👍

@wolfboys wolfboys closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants