Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize helm script #3972

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

lintingbin
Copy link

What changes were proposed in this pull request

Brief change log

  1. Remove command: ["bash","-c","bash ./bin/streampark.sh start_docker"] to fix the issue where it cannot start.
  2. Add volume-related configurations to facilitate users to insert their own k8s storage configurations.
  3. Add TLS-related configurations to ingress.
  4. Optimize RBAC configurations by adding edit permissions for the default serviceaccount in the namespace, to prevent permission issues for new users when starting Flink.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): no

Copy link

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit a2b7606 into apache:dev-2.1.5 Aug 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants