examples: ensure the proper build order #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DemesneGH Can you trigger the CI here? |
jbech-linaro
force-pushed
the
fix-build-dependencies
branch
2 times, most recently
from
90f27b4 to
3b98cab
Compare
|
R-B tag added and fixed a repetition in the commit message. |
|
|
The Makefiles for the examples lacked dependencies between rules, resulting in some cases a build error. To maintain a coherent build process, this commit introduces dependencies to ensure that binaries are built before being stripped and signed. Signed-off-by: Joakim Bech <[email protected]> Tested-by: Joakim Bech <[email protected]> Reviewed-by: Sumit Garg <[email protected]> Acked-by: Yuan Zhuang <[email protected]>
jbech-linaro
force-pushed
the
fix-build-dependencies
branch
from
3b98cab to
711e11e
Compare
|
Thanks @DemesneGH ! Looked like the CI passed, I've added your Acked-by tag and force pushed. Squashed, rebased and tag(s) applied (should be) ready for merge! Thanks! |
|
Thanks @b49020 and @DemesneGH for the quick turn around time on this one! Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefiles for the examples lacked dependencies between rules, resulting in some cases resulted in build error. To maintain a coherent build process, this commit introduces dependencies to ensure that binaries are built before being stripped and signed.