Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing identifiers for RSA and elliptic curves #125

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

samitolvanen
Copy link
Contributor

optee-utee is missing a few algorithm and attribute identifiers required for implementing AOSP KeyMint TA [1]. Add the missing RSA and ECC constants.

[1] https://android.googlesource.com/platform/system/keymint/

optee-utee is missing a few algorithm and attribute identifiers
required for implementing AOSP KeyMint TA [1].  Add the missing
RSA and ECC constants.

[1] https://android.googlesource.com/platform/system/keymint/
@DemesneGH DemesneGH merged commit 58587f2 into apache:master Apr 22, 2024
3 checks passed
@DemesneGH
Copy link
Contributor

Merged, thanks!
BTW, If your TA doesn't require the std (means all third-party crates it has imported don't need std) it's recommended to use our no-std branch which is more up-to-date with OPTEE version and has better performance. If you're interested in it see here: https://github.com/apache/incubator-teaclave-trustzone-sdk/tree/no-std

@samitolvanen
Copy link
Contributor Author

Yes, we've been using the no-std branch. Do you cherry-pick changes from master to the no-std branch, or is there something I should do to get this merged there too?

@DemesneGH
Copy link
Contributor

DemesneGH commented Apr 23, 2024

Do you cherry-pick changes from master to the no-std branch

I'll do that.
It's nice to open the PR on no-std branch the next time, thanks!

@DemesneGH
Copy link
Contributor

synced to a2491db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants