[TOREE-545] Upgrade Scalatest 3.2 and Mockito 4

[pan3793]

This is part of #199

Co-authored-by: Luciano Resende [email protected]
Co-authored-by: Cheng Pan [email protected]

This PR aims to upgrade scalatest to 3.2 and the corresponding mockito to 4.11 to prepare support for Scala 2.13

The change is verified by examples/magic-tutorial.ipynb

[pan3793]

This is a Scala bug, fixed in 2.13.0. A workaround is required to make it happy with Scala 2.12.
scala/scala#7680

[pan3793]

@lresende would you mind taking a look at this PR? it is based on your previous in-progress work.

[lresende]

@pan3793 I believe this is mostly done in #199, and I was wondering what would be best here. Contribute things in pieces because #199 updates scala do 2.13? Or should we continue adding to that PR to fix the remaining few test issues and merge #199 pr?

[pan3793]

@lresende this PR is ready to go(review and merge) on my side.

I was wondering what would be best here.

In short words, I intend to make each PR focus on one goal, especially, the large goal should be broken down into small/middle ones, which are easy to implement and review.

For #199, technically, I think it is still far from the goal, because

1. I and @requaos reached a consensus that we should not drop Scala 2.12 in Spark 3.x periods, as I explained before, Spark 3.x uses Scala 2.12 in default, it rarely uses the non-default Scala version in production.

   (from @requaos) Planning forward to support both Scala 2.12 and 2.13, with a default preference for 2.12, will be most optimal.

   Scala2.13 + Spark v3.3 #199's approach totally breaks the Scala 2.12 support.

2. coursier upgrading involves some breaking changes, Scala2.13 + Spark v3.3 #199 silently changed the logging behavior(no test coverage). It is also worth accomplishing in an independent PR.

3. Scala2.13 + Spark v3.3 #199 contains many irrelevant changes, e.g. it upgraded Java 8 to 11, and it's hard to thoroughly review with so many lines of change.

As @requaos said, I think he also agrees to break it down.

... this is a larger effort than initially planned ...

Please let me know what I can do to prepare this PR into the singular context of Scala 2.13 support.

I can accommodate upstream changes in my fork to assist in this effort. As you see fit to divide this labor, I will gladly reduce the scope of my PR to reflect an incremental task to work more gradually towards our shared goal.

@lresende That's my opinion, my goal is to accomplish the upgrading quickly, keep code quality, and make the code change history clear. Please let me know if you have any other thoughts :)

[pan3793]

all are test only, so no need to update LICENSE/NOTICE

[pan3793]

BTW, mockito-inline is introduced to support mock final class / enum

[pan3793]

The test failure is irrelevant, it's another known flaky test, will investigate independently.

[info]   - should send a status idle message after the reply and result *** FAILED *** (15 seconds, 40 milliseconds)
[info]     0 did not equal 2 (ExecuteRequestHandlerSpec.scala:193)
[info]     org.scalatest.exceptions.TestFailedException:
[info]     at org.scalatest.matchers.MatchersHelper$.indicateFailure(MatchersHelper.scala:397)
[info]     at org.scalatest.matchers.should.Matchers$ShouldMethodHelperClass.shouldMatcher(Matchers.scala:7299)
[info]     at org.scalatest.matchers.should.Matchers$AnyShouldWrapper.should(Matchers.scala:7362)
[info]     at org.apache.toree.kernel.protocol.v5.handler.ExecuteRequestHandlerSpec.$anonfun$new$6(ExecuteRequestHandlerSpec.scala:193)

[pan3793]

@lresende I opened #218 based on this PR (I have to open a new PR because I don't have permission to commit on the original PR branch), which is a rough and dirty fix of #199, it passed building and testing on both Scala 2.12 and 2.13. I would like to continue the work after this PR get in.

[pan3793]

@lresende do you have further concerns about shipping this patch?

[pan3793]

This PR only touches the test code, since all tests passed and no further objections, I'm going to merge it to unblock Scala 2.13 upgrading tasks.