Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOREE-547] Remove unnecessary Java options #213

Merged
merged 3 commits into from
Aug 10, 2023
Merged

[TOREE-547] Remove unnecessary Java options #213

merged 3 commits into from
Aug 10, 2023

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Aug 10, 2023 •
edited
Loading

I see the following warning in the testing output

OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=1024M; support was removed in 8.0

I propose to remove the legacy or already be enabled by default Java options.

  1. MaxPermSize: replaced by MetaspaceSize in Java 8
  2. +UseCompressedOops: enabled by default in Java 8
  3. +UseCompressedClassPointers: enabled by default in Java 8
  4. +TieredCompilation: enabled by default in Java 8
  5. +CMSClassUnloadingEnabled: CMS is deprecated since Java 9
  6. +UseConcMarkSweepGC: CMS is deprecated since Java 9

And keep build.sbt consistent consistent w/ .jvmopts as said

// Options provided to forked JVMs through sbt, based on our .jvmopts file

@lresende lresende merged commit 61380e8 into apache:master Aug 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lresende lresende lresende approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pan3793 @lresende