[TOREE-553] Correct the behavior of make dev
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Sep 8, 2023
| @@ -161,7 +161,7 @@ dist: dist/toree pip-release | |||
| dev: DOCKER_WORKDIR=/srv/toree/etc/examples/notebooks | |||
| dev: SUSPEND=n | |||
| dev: DEBUG_PORT=5005 | |||
| dev: .toree-dev-image dist | |||
| dev: dist .toree-dev-image | |||
There was a problem hiding this comment.
I think it's a bug, we should do dist first, so that the Dockerfile's ADD command could see the artifacts.
incubator-toree/Dockerfile.toree-dev
Line 52 in 937c126
pan3793
commented
Sep 8, 2023
pan3793
changed the title
make devmake dev
|
@lresende, I found this issue during debug phase, would you please take a look? |
|
@lresende I have reverted the debatable change, can we consider getting the rest change in? |
lresende
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the developer experience of the command
make dev.Previously, after changing the code, running
make devdoes not pick up the new assembly artifacts, which is not convenient for developers.After the change,
make devbecomes intuitive, it always picks up the latest assembly artifacts.