[#1651] improvement(netty): Set Netty as the default server type #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
MR/TEZ don't support Netty now. I hesitate to make it default. |
Test Results 2 657 files ±0 2 657 suites ±0 5h 31m 56s ⏱️ - 1m 36s For more details on these failures, see this check. Results for commit 7045e72. ± Comparison against base commit f984efb. ♻️ This comment has been updated with latest results. |
|
OK, I'll keep this PR here. When it is ready, anyone can modify on top of this PR. |
|
@maobaolong I think you can continue working on this PR. |
|
@rickyma Ok, thanks for the effort before! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set Netty as the default server type.
Why are the changes needed?
For: #1651.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.