Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1945] Improvement(server): Remove PreAllocated buffer earlier by unregisterPureEvent #1970

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maobaolong
Copy link
Member

@maobaolong maobaolong commented Jul 27, 2024

What changes were proposed in this pull request?

Index PreAllocatedBufferInfo by appId, base on this, remove all PreAllocatedBufferInfos related an appId which invoked by UnregisterAppPurgeEvent handle method.

Why are the changes needed?

(Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.)

Fix: #1945

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Test pressure test case on our test cluster.

@maobaolong maobaolong changed the title Remove PreAllocated buffer earlier by unregisterPureEvent [#1945] Improvement(server): Remove PreAllocated buffer earlier by unregisterPureEvent Jul 27, 2024
Copy link

github-actions bot commented Jul 27, 2024

Test Results

 2 432 files   - 315   2 432 suites   - 315   6h 55m 18s ⏱️ - 2h 55m 40s
   903 tests  -  76     897 ✅  -  81   1 💤 ±0   5 ❌ + 5 
11 681 runs   - 613  11 592 ✅  - 687  15 💤 ±0  74 ❌ +74 

For more details on these failures, see this check.

Results for commit e284519. ± Comparison against base commit 457c865.

This pull request removes 76 tests.
org.apache.uniffle.test.AQERepartitionTest ‑ resultCompareTest
org.apache.uniffle.test.AQESkewedJoinTest ‑ resultCompareTest
org.apache.uniffle.test.AQESkewedJoinWithLocalOrderTest ‑ resultCompareTest
org.apache.uniffle.test.AutoAccessTest ‑ test
org.apache.uniffle.test.CombineByKeyTest ‑ combineByKeyTest
org.apache.uniffle.test.ContinuousSelectPartitionStrategyTest ‑ resultCompareTest
org.apache.uniffle.test.DynamicConfTest ‑ dynamicConfTest
org.apache.uniffle.test.DynamicFetchClientConfTest ‑ test
org.apache.uniffle.test.FailingTasksTest ‑ testFailedTasks
org.apache.uniffle.test.GetReaderTest ‑ test
…

♻️ This comment has been updated with latest results.

@maobaolong maobaolong marked this pull request as draft July 29, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Release preAllocatedBuffer when unregisterShuffleByAppId request
1 participant