[#2015] improvement(netty): Support Netty for MR integration test. #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2016 +/- ##
============================================
+ Coverage 52.35% 52.87% +0.52%
- Complexity 2815 3424 +609
============================================
Files 452 518 +66
Lines 21217 28352 +7135
Branches 1950 2650 +700
============================================
+ Hits 11108 14992 +3884
- Misses 9401 12394 +2993
- Partials 708 966 +258 ☔ View full report in Codecov by Sentry. |
Test Results 2 926 files +31 2 926 suites +31 6h 15m 20s ⏱️ + 28m 15s Results for commit 1a64acf. ± Comparison against base commit f9b4c0e. This pull request removes 6 and adds 12 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
rickyma
changed the title
jerqi
pushed a commit
that referenced
this pull request
Sep 25, 2024
…using ShuffleBufferWithSkipList. (#2141) ### What changes were proposed in this pull request? Release duplicate block. #2016 solve this problem in client side. I think sendShuffeData may be retried, duplicated block still be reproduce. ### Why are the changes needed? Fix: #2105 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? test in cluster.
|
LGTM! wait for ci! |
zhengchenyu
approved these changes
Oct 21, 2024
maobaolong
pushed a commit
to maobaolong/incubator-uniffle
that referenced
this pull request
Nov 4, 2024
… when using ShuffleBufferWithSkipList. (apache#2141) ### What changes were proposed in this pull request? Release duplicate block. apache#2016 solve this problem in client side. I think sendShuffeData may be retried, duplicated block still be reproduce. ### Why are the changes needed? Fix: apache#2105 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? test in cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support Netty for MR integration test.
Why are the changes needed?
Fix: #2015
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Integration tests themselves.