Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTDB-6328] Add optimization for aggregation query in align by device with template situation #12513

Merged
merged 35 commits into from
May 28, 2024

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented May 11, 2024

Description

This pull request is a follow up optimization of #11783.

When all queried devices is set in one device template, we don't need to serialize the related variables as the count of devices, we just need extracted the common variables and serialize and deserialize them for once.

The experiments result is in this link: https://apache-iotdb.feishu.cn/docx/Pp7sdOucCoMLNTxyA9dce6OXnLe

@Beyyes Beyyes marked this pull request as draft May 11, 2024 12:58
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 6.27675% with 657 lines in your changes are missing coverage. Please review.

Project coverage is 42.97%. Comparing base (cb1bca6) to head (b6acca4).
Report is 1 commits behind head on master.

Files Patch % Lines
...queryengine/plan/planner/TemplatedLogicalPlan.java 0.00% 143 Missing ⚠️
...gine/plan/analyze/TemplatedAggregationAnalyze.java 0.00% 114 Missing ⚠️
...tdb/db/queryengine/plan/analyze/TemplatedInfo.java 0.00% 87 Missing ⚠️
...ueryengine/plan/planner/OperatorTreeGenerator.java 9.52% 76 Missing ⚠️
...yengine/plan/optimization/AggregationPushDown.java 18.39% 71 Missing ⚠️
.../db/queryengine/plan/analyze/TemplatedAnalyze.java 3.77% 51 Missing ⚠️
.../node/source/AlignedSeriesAggregationScanNode.java 3.22% 30 Missing ⚠️
...ine/plan/planner/plan/node/process/FilterNode.java 17.85% 23 Missing ⚠️
...plan/planner/plan/node/process/DeviceViewNode.java 0.00% 21 Missing ⚠️
...gine/plan/planner/TemplatedLogicalPlanBuilder.java 0.00% 17 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12513      +/-   ##
============================================
- Coverage     43.09%   42.97%   -0.12%     
  Complexity       69       69              
============================================
  Files          3190     3191       +1     
  Lines        198299   198847     +548     
  Branches      23613    23707      +94     
============================================
+ Hits          85459    85460       +1     
- Misses       112840   113387     +547     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Beyyes Beyyes marked this pull request as ready for review May 28, 2024 06:05
@Beyyes Beyyes changed the title Add aggregation template align by device optimization Add optimization for aggregation query in align by device with template situation May 28, 2024
@Beyyes Beyyes changed the title Add optimization for aggregation query in align by device with template situation [IOTDB-6328] Add optimization for aggregation query in align by device with template situation May 28, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
4.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Beyyes Beyyes merged commit 1af2c23 into master May 28, 2024
57 of 59 checks passed
@Beyyes Beyyes deleted the beyyes/agg_template_alignbydevice branch May 28, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants