Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid auto create database when disable auto create schema #12590

Merged
merged 2 commits into from
May 30, 2024

Conversation

CRZbulabula
Copy link
Contributor

A little update as the title described

Copy link
Member

@wangchao316 wangchao316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 43.07%. Comparing base (aa2687c) to head (c07835b).
Report is 29 commits behind head on master.

Files Patch % Lines
...ryengine/plan/analyze/ClusterPartitionFetcher.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12590      +/-   ##
============================================
- Coverage     43.37%   43.07%   -0.30%     
  Complexity       69       69              
============================================
  Files          3164     3203      +39     
  Lines        196704   200038    +3334     
  Branches      23431    23852     +421     
============================================
+ Hits          85316    86175     +859     
- Misses       111388   113863    +2475     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Add IT

Copy link

Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 91b8f40 into master May 30, 2024
37 of 40 checks passed
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the ban-auto-create-db branch May 30, 2024 08:14
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants