Fix that config changes rejected by DN will be written to CN's config #14551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14551 +/- ##
=========================================
Coverage 39.42% 39.42%
Complexity 185 185
=========================================
Files 4341 4341
Lines 275397 275406 +9
Branches 33639 33641 +2
=========================================
+ Hits 108566 108588 +22
+ Misses 166831 166818 -13 ☔ View full report in Codecov by Sentry. |
This reverts commit f6bf884.
shuwenwei
reviewed
Dec 26, 2024
| }); | ||
| } else { | ||
| // not for this node, ignore it | ||
| return tsStatus; |
There was a problem hiding this comment.
When the set configuration target is not this node, should it be forwarded through nodeManager?
|
shuwenwei
approved these changes
Dec 27, 2024
CloudWise-Lukemiao
pushed a commit
to CloudWise-Lukemiao/iotdb
that referenced
this pull request
Dec 27, 2024
…apache#14551) * Fix that config changes rejected by DN will be written to CN's config file * fix test (cherry picked from commit e15012c) * fix test * Revert "fix test" This reverts commit f6bf884. * fix not forwarded config
shuwenwei
pushed a commit
to shuwenwei/iotdb
that referenced
this pull request
Dec 30, 2024
…s config (apache#14551)" This reverts commit 2c4bb24.
shuwenwei
added a commit
to shuwenwei/iotdb
that referenced
this pull request
Dec 30, 2024
…s config (apache#14551)" This reverts commit 2c4bb24.
jt2594838
added a commit
that referenced
this pull request
Dec 30, 2024
…s config (#14551)" (#14589) This reverts commit 2c4bb24. Co-authored-by: Jiang Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.