Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the issue of NPE caused by unexpected exceptions thrown during the use of AsyncClient #14556

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Fixed the issue of NPE caused by unexpected exceptions thrown during the use of AsyncClient #14556

merged 1 commit into from
Dec 26, 2024
+12 −5

Conversation

luoluoyuyu
Copy link
Contributor

Description

As the title said

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@luoluoyuyu luoluoyuyu changed the title Pipe: Fixed the issue of NPE caused by unexpected exceptions thrown during the use of AsyncClient Fixed the issue of NPE caused by unexpected exceptions thrown during the use of AsyncClient Dec 26, 2024
OneSizeFitsQuorum
OneSizeFitsQuorum approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 80e564b into apache:master Dec 26, 2024
34 of 35 checks passed
luoluoyuyu added a commit to luoluoyuyu/iotdb that referenced this pull request Dec 26, 2024
@luoluoyuyu
Pipe: Fixed the issue of NPE caused by unexpected exceptions thrown d…
0ab4881 
…uring the use of AsyncClient. (apache#14556)

(cherry picked from commit 80e564b)
SteveYurongSu pushed a commit that referenced this pull request Dec 26, 2024
@luoluoyuyu
Fixed the issue of NPE caused by unexpected exceptions thrown during …
c87d6df 
…the use of AsyncClient. (#14556) (#14563)

(cherry picked from commit 80e564b)
@SteveYurongSu SteveYurongSu self-assigned this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caideyipi Caideyipi Caideyipi approved these changes

@OneSizeFitsQuorum OneSizeFitsQuorum OneSizeFitsQuorum approved these changes

Assignees

@SteveYurongSu SteveYurongSu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luoluoyuyu @OneSizeFitsQuorum @Caideyipi @SteveYurongSu