Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource leak for MemoryMailRepository #2214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix resource leak for MemoryMailRepository #2214

wants to merge 1 commit into from

Conversation

vttranlina
Copy link
Contributor

  • Fix error: Leak detected! Resource org.apache.james.server.core.MimeMessageInputStreamSource$Resource@xxxx was not released before its referent was garbage-collected.

Note:

  • I see the commit linagora@d6d68d6 changed the code from save directly mail to save cloneMail

I reverted it and the MailRepositoryContract still passed

@vttranlina
Fix resource leak for MemoryMailRepository
1676985 
- Fix error: Leak detected! Resource org.apache.james.server.core.MimeMessageInputStreamSource$Resource@xxxx was not released before its referent was garbage-collected.
@vttranlina vttranlina mentioned this pull request Apr 23, 2024
Closed
chibenwa
chibenwa requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By working on the email I get from the repo, I actively modify it.

This sort of mutability is dangerous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibenwa chibenwa chibenwa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vttranlina @chibenwa