AmqpForwardAttribute mailet: ignore errors when creating an exchange that already exists with a different configuration. #2414
+238
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that already exists with a different configuration.
chibenwa
reviewed
Sep 19, 2024
mailet/amqp/src/main/java/org/apache/james/transport/mailets/AmqpForwardAttribute.java
Show resolved
Hide resolved
|
Read it. |
Arsnael
approved these changes
Sep 20, 2024
|
I renamed |
…change that already exists with a different configuration. - add test cases
vttranlina
force-pushed
the
AmqpForwardAttribute
branch
from
c98fd43
to
79420b6
Compare
Arsnael
approved these changes
Sep 20, 2024
chibenwa
approved these changes
Sep 20, 2024
quantranhong1999
approved these changes
Sep 20, 2024
it does not relate to this pr, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will help us avoid starting James with failures.
Additionally, with each parameter configuration (e.g., durable, autoDelete, internal, passive), we do not need to have the same argument settings in the mailetcontainer.