Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOHNZON-398: full JPMS support via module-info.java mechanism #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SingingBush
Copy link
Contributor

This is a follow up to #99 which merely configured Automatic-Module-Name

  • Updated a few maven plugins
  • Add module-info.java to all sub-projects that makes sense to do so
  • Remove Automatic-Module-Name in all sub-projects that now have module-info.java
  • Also added a README.md

Copy link
Contributor

@rmannibucau rmannibucau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I'd like to stay in unamed module cause jpms is kind of born dead IMHO and the current pr misses some "static" in requirements making the dep stack no more accurate.
I'd also like to not maintain both mvn and module files but anyway jpms is not a thing and moving out of unamed module breaks apps so not a trivial change until we do it in classified ("jpms") jars IMHO.

@SingingBush
Copy link
Contributor Author

No problem. May be worth keeping the branch for reference. I'd like to know more about how the intended approach to JPMS would work and can potentially have a go at redoing the PR. I have no legacy projects in my current firm so have been able to make use of modules in all codebases. Personally I find it great and can use the maven jlink plugin to build small apps.

@rmannibucau
Copy link
Contributor

Have to admit we tested jlink and found no advantage over plain custom jvm (but same licenses issues), we tend to move to graalvm for small and optimized apps (with arthur for a trivial jsonb integration) or plain jvm for other oci apps to leverage layer cache so jlink is really something in between without much real use cases IMHO. Most of the use case i saw was perf boost of wrongly configured app (not comparable scanning due to module usage) and adoption stays low in the ecosystem.
That said the breaking change is more an immediate blocker but happy to get classified jar if it helps you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants