KAFKA-18272: Deprecated protocol api usage should be logged at info level #18313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evel This makes it possible to enable request logs for deprecated protocol api versions without enabling it for the rest. Combined with the ability to enable/disable dynamically, it makes it a bit easier to collect the information about deprecated clients that is not available via metrics.
github-actions
bot
added
triage
chia7712
approved these changes
Dec 27, 2024
| requestLogger.debug("Completed request:" + desc.toString) | ||
| val logPrefix = "Completed request: {}" | ||
| // log deprecated apis at `info` level to allow them to be selectively enabled | ||
| if (header.apiKey().isVersionDeprecated(header.apiVersion())) |
There was a problem hiding this comment.
Perhaps we can add a helper method to header to directly check for deprecated versions, such as header.isVersionDeprecated()
There was a problem hiding this comment.
Good point, pushed a commit with this change.
chia7712
approved these changes
Dec 27, 2024
ijuma
deleted the
kafka-18272-deprecated-protocol-api-usage-should-be-logged-at-info-level
branch
ijuma
added a commit
that referenced
this pull request
Dec 27, 2024
…evel (#18313) This makes it possible to enable request logs for deprecated protocol api versions without enabling it for the rest. Combined with the ability to enable/disable dynamically, it makes it a bit easier to collect the information about deprecated clients that is not available via metrics. This isn't particularly useful in trunk/4.0 since there are no deprecated api versions in these versions, but it will be useful for older branches. I intend to backport to those branches and add a release note in the backport regarding the change in behavior. I manually verified that: 1. If the request logger is configured at `INFO` level, only deprecated protocol api versions are logged and they are logged at `INFO` level. 2. If the request logger is configured at `DEBUG` level, all requests are logged but the log level is `INFO` for deprecated protocol api versions and `DEBUG` for the rest. 3. If the request logger is configured at `WARN` level (the default), no requests are logged. Reviewers: Chia-Ping Tsai <[email protected]>
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Dec 27, 2024
…evel (apache#18313) This makes it possible to enable request logs for deprecated protocol api versions without enabling it for the rest. Combined with the ability to enable/disable dynamically, it makes it a bit easier to collect the information about deprecated clients that is not available via metrics. This isn't particularly useful in trunk/4.0 since there are no deprecated api versions in these versions, but it will be useful for older branches. I intend to backport to those branches and add a release note in the backport regarding the change in behavior. I manually verified that: 1. If the request logger is configured at `INFO` level, only deprecated protocol api versions are logged and they are logged at `INFO` level. 2. If the request logger is configured at `DEBUG` level, all requests are logged but the log level is `INFO` for deprecated protocol api versions and `DEBUG` for the rest. 3. If the request logger is configured at `WARN` level (the default), no requests are logged. Reviewers: Chia-Ping Tsai <[email protected]>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…evel (apache#18313) This makes it possible to enable request logs for deprecated protocol api versions without enabling it for the rest. Combined with the ability to enable/disable dynamically, it makes it a bit easier to collect the information about deprecated clients that is not available via metrics. This isn't particularly useful in trunk/4.0 since there are no deprecated api versions in these versions, but it will be useful for older branches. I intend to backport to those branches and add a release note in the backport regarding the change in behavior. I manually verified that: 1. If the request logger is configured at `INFO` level, only deprecated protocol api versions are logged and they are logged at `INFO` level. 2. If the request logger is configured at `DEBUG` level, all requests are logged but the log level is `INFO` for deprecated protocol api versions and `DEBUG` for the rest. 3. If the request logger is configured at `WARN` level (the default), no requests are logged. Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to enable request logs for deprecated protocol api versions without enabling it for the rest. Combined with the ability to enable/disable dynamically, it makes it a bit easier to collect the information about deprecated clients that is not available via metrics.
This isn't particularly useful in trunk/4.0 since there are no deprecated api versions in these versions, but it will be useful for older branches. I intend to backport to those branches and add a release note in the backport regarding the change in behavior.
I manually verified that:
INFOlevel, only deprecated protocol api versions are logged and they are logged atINFOlevel.DEBUGlevel, all requests are logged but the log level isINFOfor deprecated protocol api versions andDEBUGfor the rest.WARNlevel (the default), no requests are logged.Committer Checklist (excluded from commit message)