Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOX-2930 - Fix OM and SCM UIs to work in HA #767

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

dombizita
Copy link
Contributor

@dombizita dombizita commented Jun 28, 2023

What changes were proposed in this pull request?

Previously if there were multiple OMs/SCMs in a cluster on the Knox UI if you clicked on any of the OM/SCM UIs it was consistently showing one of the OMs/SCMs UI, because $serviceUrl[OZONE-SCM] was picking the first URL from the three in the cdp-proxy.xml.

In this fix I add a ?host={host} to the ending of the URLs and used that {host} later when rewriting the requests, so it will go to the correct host. I added a separate route for the documentation to work in the UIs.

How was this patch tested?

I tested it in a cluster and all the 3 OMs/SCMs cards on the Knox UI page are redirecting to the corresponding OM/SCM UI page.

OM UI:

om_ui

SCM UI:

scm_ui

upstream docs page loading through Knox:

docs

Copy link
Contributor

@smolnar82 smolnar82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@zeroflag - Could you please check this out too?

Copy link
Contributor

@zeroflag zeroflag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroflag zeroflag merged commit dc00e67 into apache:master Jul 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants