Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOX-2936 - knoxcli convert-topology doesn't work with output-path parameter #770

Merged
merged 1 commit into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2303,7 +2303,7 @@ public class TopologyConverter extends Command {
+ "--descriptor-name (optional) name of descriptor json config file (including .json extension) \n"
+ "--topology-name (optional) topology-name can be use instead of --path option, if used, KnoxCLI will attempt to find topology from deployed topologies.\n"
+ "\t if not provided topology name will be used as descriptor name \n"
+ "--output-path (optional) output directory to save provider and descriptor config files \n"
+ "--output-dir (optional) output directory to save provider and descriptor config files \n"
+ "\t if not provided config files will be saved in appropriate Knox config directory \n"
+ "--force (optional) force rewriting of existing files, if not used, command will fail when the configs files with same name already exist. \n"
+ "--cluster (optional) cluster name, required for service discovery \n"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,9 @@ private void fileCheck(final File file) throws IOException {
file.getAbsolutePath()));
}
/* make sure file and directories are in place */
Files.createDirectories(file.toPath().getParent());
if (!file.getParentFile().exists()) {
Files.createDirectories(file.toPath().getParent());
}
file.createNewFile();
}

Expand Down
Loading