-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KNOX-2955 - Knox Readiness Awareness and Notification #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroflag
force-pushed
the
KNOX-2955-ready
branch
from
September 6, 2023 11:23
f305e24
to
aefd0a2
Compare
pzampino
reviewed
Sep 7, 2023
...rver/src/main/java/org/apache/knox/gateway/services/factory/GatewayStatusCheckerFactory.java
Outdated
Show resolved
Hide resolved
gateway-service-health/src/main/java/org/apache/knox/gateway/service/health/PingResource.java
Outdated
Show resolved
Hide resolved
...ay-service-health/src/test/java/org/apache/knox/gateway/service/health/PingResourceTest.java
Outdated
Show resolved
Hide resolved
...erver/src/main/java/org/apache/knox/gateway/services/topology/impl/GatewayStatusChecker.java
Outdated
Show resolved
Hide resolved
pzampino
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
smolnar82
requested changes
Sep 8, 2023
gateway-server/src/main/java/org/apache/knox/gateway/GatewayMessages.java
Outdated
Show resolved
Hide resolved
gateway-server/src/main/java/org/apache/knox/gateway/GatewayMessages.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/org/apache/knox/gateway/services/factory/GatewayStatusCheckerFactory.java
Outdated
Show resolved
Hide resolved
...erver/src/main/java/org/apache/knox/gateway/services/topology/impl/GatewayStatusService.java
Show resolved
Hide resolved
...r/src/test/java/org/apache/knox/gateway/services/topology/impl/GatewayStatusServiceTest.java
Outdated
Show resolved
Hide resolved
gateway-service-health/src/main/java/org/apache/knox/gateway/service/health/PingResource.java
Show resolved
Hide resolved
gateway-service-health/src/main/java/org/apache/knox/gateway/service/health/PingResource.java
Outdated
Show resolved
Hide resolved
smolnar82
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding a new endpoint to the health service for checking knox gateway status (weather all topologies which were available at startup are deployed)
How was this patch tested?
Create discovery password:
Adding this to gateway-site.xml
Dedicated topology for checking gateway status:
Hadoop xml resource file:
Starting gw:
Log:
Script for polling health endpoint
Script Output