KNOX-3020 - Introducing the 'type' metadata for Knox Tokens #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moresandeep
approved these changes
Mar 14, 2024
gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/TokenMetadata.java
Show resolved
Hide resolved
gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/TokenMetadata.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduced new metadata called
type, this can be any of:The default is
JWT. TheKNOXSSO_COOKIEis set when tokens are participating in KNOX SSO Cookie management we introduced in #797 .CLIENT_IDcan be set via a KnoxToken API call with metadata name,type. For instance:The Token Management UI is updated: instead of adding new columns per type, only a one column exists and the relevant type icon is displayed.
How was this patch tested?
Ran build/unit tests and deployed Knox. Then I
curlrequest to generate aCLIENT_IDtype tokenConfirmed the tokens were created and they were displayed properly on the Token Management UI: