KNOX-3026 - End-users can exclude certain services or roles from CM service discovery #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzampino
reviewed
Mar 27, 2024
...main/java/org/apache/knox/gateway/topology/discovery/cm/ClouderaManagerServiceDiscovery.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/knox/gateway/topology/discovery/cm/ClouderaManagerServiceDiscovery.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I added two new gateway-level configurations:
gateway.cloudera.manager.service.discovery.excluded.service.typesgateway.cloudera.manager.service.discovery.excluded.role.typesBoth configurations can store a collection of comma-separated Cloudera Manager service or role types that should be excluded from CM service discovery. They both default to an empty set, meaning full CM discovery.
During a CM service discovery attempt, those configurations are checked and based on the supplied values the discovery logic skips the given service(s) or role(s) discovery.
How was this patch tested?
I added and updated existing JUnit tests.
Tested on a live CM cluster:
After restarting Knox, I exported discovery-related logs into cm_discovery.txt
Here is the list of relevant log entries for this PR: