Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOX-3044 - Port numbers are written with ',' format in logs #919

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

senthh
Copy link
Contributor

@senthh senthh commented Jun 19, 2024

(It is very important that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)

What changes were proposed in this pull request?

Modified GatewayMessages, GatewayServer such that port number will be written without ',' character.

Log message before change : Port 1,243 is already in use.

Log message after change : Port 1243 is already in use.

How was this patch tested?

Tested with Existing GatewayPortMappingConfigTest testsuite.

@senthh
Copy link
Contributor Author

senthh commented Jun 19, 2024

@moresandeep , @lmccay could you please review this trivial changes?

1 similar comment
@senthh
Copy link
Contributor Author

senthh commented Jun 21, 2024

@moresandeep , @lmccay could you please review this trivial changes?

@smolnar82 smolnar82 self-requested a review July 4, 2024 06:19
Copy link
Contributor

@smolnar82 smolnar82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smolnar82 smolnar82 merged commit 529bf24 into apache:master Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants