KNOX-3054 - Replace ignored meta tag cache headers to HTTP headers #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzampino
reviewed
Aug 1, 2024
gateway-server/src/main/java/org/apache/knox/gateway/GatewayFilter.java
Outdated
Show resolved
Hide resolved
pzampino
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modern browsers ignore caching headers as meta elements. Due to this Firefox loads index.html from cache and the user won't be redirected to the Knox login page when there is no Cookie present and the user can't use the homepage.
How was this patch tested?
Added new tests.
Manually tested by loading the home page and checking for the new headers in the HTTP response.
Please review Knox Contributing Process before opening a pull request.