Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KYUUBI #5822] Fix the usage msg of KyuubiBeeLine #5823

Closed
wants to merge 1 commit into from
Closed

[KYUUBI #5822] Fix the usage msg of KyuubiBeeLine #5823

wants to merge 1 commit into from

Conversation

hadoopkandy
Copy link
Contributor

@hadoopkandy hadoopkandy commented Dec 6, 2023 •
edited by pan3793
Loading

🔍 Description

Issue References 🔗

This pull request fixes #5822

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

$ $KYUUBI_HOME/bin/beeline --help
...
Usage: java " + KyuubiBeeLine.class.getCanonicalName()
...

Behavior With This Pull Request 🎉

$ $KYUUBI_HOME/bin/beeline --help
...
Usage: java org.apache.hive.beeline.KyuubiBeeLine
...

Related Unit Tests

Checklists

📝 Author Self Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

  • Pull request title is okay.
  • No license issues.
  • Milestone correctly set?
  • Test coverage is ok
  • Assignees are selected.
  • Minimum number of approvals
  • No changes are requested

Be nice. Be informative.

@cxzl25 cxzl25 changed the title [KYUUBI #5822][doc] Fix the usage msg of KyuubiBeeLine [KYUUBI #5822][DOC] Fix the usage msg of KyuubiBeeLine Dec 6, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e779b42) 61.34% compared to head (a46b6e4) 61.25%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5823      +/-   ##
============================================
- Coverage     61.34%   61.25%   -0.10%     
  Complexity       23       23              
============================================
  Files           608      608              
  Lines         36027    36027              
  Branches       4951     4951              
============================================
- Hits          22101    22067      -34     
- Misses        11542    11565      +23     
- Partials       2384     2395      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 changed the title [KYUUBI #5822][DOC] Fix the usage msg of KyuubiBeeLine [KYUUBI #5822] Fix the usage msg of KyuubiBeeLine Dec 7, 2023
@pan3793 pan3793 added this to the v1.7.4 milestone Dec 7, 2023
@pan3793 pan3793 closed this in 5b3a78d Dec 7, 2023
pan3793 pushed a commit that referenced this pull request Dec 7, 2023
@hadoopkandy @pan3793
[KYUUBI #5822] Fix the usage msg of KyuubiBeeLine
0c748a2 
# 🔍 Description
## Issue References 🔗

This pull request fixes #5822

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

```
$ $KYUUBI_HOME/bin/beeline --help
...
Usage: java " + KyuubiBeeLine.class.getCanonicalName()
...
```

#### Behavior With This Pull Request 🎉

```
$ $KYUUBI_HOME/bin/beeline --help
...
Usage: java org.apache.hive.beeline.KyuubiBeeLine
...
```

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [x] I have performed a self-review
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [x] Pull request title is okay.
- [x] No license issues.
- [x] Milestone correctly set?
- [ ] Test coverage is ok
- [x] Assignees are selected.
- [x] Minimum number of approvals
- [x] No changes are requested

**Be nice. Be informative.**

Closes #5823 from hadoopkandy/KYUUBI-5822.

Closes #5822

a46b6e4 [kandy01.wang] [KYUUBI #5822][doc] Fix the usage msg of KyuubiBeeLine

Authored-by: kandy01.wang <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 5b3a78d)
Signed-off-by: Cheng Pan <[email protected]>
pan3793 pushed a commit that referenced this pull request Dec 7, 2023
@hadoopkandy @pan3793
[KYUUBI #5822] Fix the usage msg of KyuubiBeeLine
b244475 
# 🔍 Description
## Issue References 🔗

This pull request fixes #5822

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

```
$ $KYUUBI_HOME/bin/beeline --help
...
Usage: java " + KyuubiBeeLine.class.getCanonicalName()
...
```

#### Behavior With This Pull Request 🎉

```
$ $KYUUBI_HOME/bin/beeline --help
...
Usage: java org.apache.hive.beeline.KyuubiBeeLine
...
```

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [x] I have performed a self-review
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [x] Pull request title is okay.
- [x] No license issues.
- [x] Milestone correctly set?
- [ ] Test coverage is ok
- [x] Assignees are selected.
- [x] Minimum number of approvals
- [x] No changes are requested

**Be nice. Be informative.**

Closes #5823 from hadoopkandy/KYUUBI-5822.

Closes #5822

a46b6e4 [kandy01.wang] [KYUUBI #5822][doc] Fix the usage msg of KyuubiBeeLine

Authored-by: kandy01.wang <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 5b3a78d)
Signed-off-by: Cheng Pan <[email protected]>
@pan3793
Copy link
Member

pan3793 commented Dec 7, 2023

Thanks, merged to master/1.8/1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenliang123 bowenliang123 bowenliang123 approved these changes

@cxzl25 cxzl25 cxzl25 approved these changes

Assignees

@hadoopkandy hadoopkandy

Labels
module:ctl module:hive
Projects
None yet
Milestone
v1.7.4
Development

Successfully merging this pull request may close these issues.

[TASK][TRIVIAL] Fix the usage msg of KyuubiBeeLine
5 participants
@hadoopkandy @codecov-commenter @pan3793 @bowenliang123 @cxzl25