Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Bump Maven from 3.8.8 to 3.9.9 #6664

Closed
wants to merge 1 commit into from

Conversation

bowenliang123
Copy link
Contributor

🔍 Description

Issue References 🔗

This pull request fixes #

Describe Your Solution 🔧

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@bowenliang123 bowenliang123 changed the title Bump maven to 3.9 Bump Maven from 3.8.8 to 3.9.9 Sep 3, 2024
@bowenliang123
Copy link
Contributor Author

Other popular projects are now using Maven 3.9, e.g. Spark , and Celeborn.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (dff40e8) to head (074b7ba).
Report is 4 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6664   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         683     683           
  Lines       42205   42205           
  Branches     5756    5756           
======================================
  Misses      42205   42205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenliang123 bowenliang123 changed the title Bump Maven from 3.8.8 to 3.9.9 [BUILD] Bump Maven from 3.8.8 to 3.9.9 Sep 4, 2024
@bowenliang123 bowenliang123 marked this pull request as ready for review September 4, 2024 01:26
@bowenliang123 bowenliang123 self-assigned this Sep 4, 2024
@bowenliang123 bowenliang123 added this to the v1.10.0 milestone Sep 4, 2024
@bowenliang123 bowenliang123 deleted the maven39 branch September 4, 2024 14:51
@bowenliang123
Copy link
Contributor Author

Thanks, merged to master (1.10.0).

@pan3793
Copy link
Member

pan3793 commented Sep 11, 2024

Seems we have used a different variable in GitHub workflows to gain the same purpose, it would be great to migrate to the official approch.

https://maven.apache.org/configure.html#maven_args-environment-variable

MAVEN_ARGS environment variable:

Starting with Maven 3.9.0, this variable contains arguments passed to Maven before CLI arguments. E.g., options and goals could be defined with the value -B -V checkstyle:checkstyle.

@bowenliang123
Copy link
Contributor Author

Seems we have used a different variable in GitHub workflows to gain the same purpose, it would be great to migrate to the official approch.

https://maven.apache.org/configure.html#maven_args-environment-variable

MAVEN_ARGS environment variable:
Starting with Maven 3.9.0, this variable contains arguments passed to Maven before CLI arguments. E.g., options and goals could be defined with the value -B -V checkstyle:checkstyle.

Cool. Sounds that MVN_OPT custom env var could be replaced by MAVEN_ARGS in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants