-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump scala-collection-compat to 2.12.0 #6677
Bump scala-collection-compat to 2.12.0 #6677
Conversation
BTW, how do you determine the exact version to bump? What's the clue or evidence? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6677 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 683 684 +1
Lines 42213 42237 +24
Branches 5755 5755
======================================
- Misses 42213 42237 +24 ☔ View full report in Codecov by Sentry. |
cb853e9
to
fd2738d
Compare
I found that this dependency is only used in |
Have some more investigation in its dependency relationship, and provide concrete evidence to it. |
5c16c6c
to
fd2738d
Compare
This is the latest iceberg dependency in the project and i found that the iceberg dependency referenced scala-collection-compat dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, merged master (1.10.0) . |
🔍 Description
Issue References 🔗
Describe Your Solution 🔧
scala-collection-compat
to 2.12.0scala-collection-compat
is used by the authz plugin testing Icebergscala-collection-compat
2.12.0,according to: https://github.com/apache/iceberg/blob/apache-iceberg-1.6.1/gradle/libs.versions.toml#L78
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.