Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scala-collection-compat to 2.12.0 #6677

Closed

Conversation

pionCham
Copy link
Contributor

@pionCham pionCham commented Sep 6, 2024

🔍 Description

Issue References 🔗

Describe Your Solution 🔧

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests

  • pass the Authz tests

Checklist 📝

Be nice. Be informative.

@pionCham
Copy link
Contributor Author

pionCham commented Sep 6, 2024

cc @bowenliang123

@bowenliang123
Copy link
Contributor

BTW, how do you determine the exact version to bump? What's the clue or evidence?

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d7219fc) to head (5c16c6c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6677   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         683     684    +1     
  Lines       42213   42237   +24     
  Branches     5755    5755           
======================================
- Misses      42213   42237   +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pionCham pionCham marked this pull request as draft September 6, 2024 13:17
@pionCham pionCham force-pushed the bump-scala-collection-compat-version branch from cb853e9 to fd2738d Compare September 9, 2024 14:12
@pionCham
Copy link
Contributor Author

pionCham commented Sep 9, 2024

BTW, how do you determine the exact version to bump? What's the clue or evidence?

I found that this dependency is only used in kyuubi-spark-authz submodule and it's dependence scope is test,so it's not actually used in the project. The bump has little impact on the project. @bowenliang123

@bowenliang123
Copy link
Contributor

Have some more investigation in its dependency relationship, and provide concrete evidence to it.

@pionCham
Copy link
Contributor Author

Have some more investigation in its dependency relationship, and provide concrete evidence to it.

<dependency>
    <groupId>org.apache.iceberg</groupId>
    <artifactId>iceberg-spark-runtime-3.5_2.12</artifactId>
    <version>1.6.1</version>
</dependency>

This is the latest iceberg dependency in the project and i found that the iceberg dependency referenced scala-collection-compat dependency.
This indicates that iceberg can reference the version number2.12.0 of scala-collection-compat
https://github.com/apache/iceberg/blob/6ff7a6ec2e2790e5d2d2b35a2091e68101ab3aa3/gradle/libs.versions.toml#L81

@pionCham pionCham marked this pull request as ready for review September 12, 2024 06:09
@bowenliang123 bowenliang123 changed the title Bump Scala Collection Compat to 2.12.0 Bump scala-collection-compat to 2.12.0 Sep 12, 2024
Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bowenliang123
Copy link
Contributor

Thanks, merged master (1.10.0) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants