Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the delete batch request in batch operation log #6681

Closed
wants to merge 1 commit into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Sep 8, 2024

🔍 Description

Issue References 🔗

As title, log the delete batch request in operation log.

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

log

unused
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (db5ce0c) to head (8550868).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../apache/kyuubi/server/api/v1/BatchesResource.scala 0.00% 5 Missing ⚠️
...org/apache/spark/kyuubi/SQLOperationListener.scala 0.00% 4 Missing ⚠️
...rg/apache/kyuubi/operation/AbstractOperation.scala 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6681   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         684     684           
  Lines       42233   42237    +4     
  Branches     5755    5755           
======================================
- Misses      42233   42237    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turboFei turboFei closed this in edbe3f3 Sep 9, 2024
@turboFei turboFei deleted the audit_kill branch September 9, 2024 16:28
@turboFei
Copy link
Member Author

turboFei commented Sep 9, 2024

thanks, merged to 1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants