Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6686] Ignore Spark pod container state if pod is terminated #6690

Closed
wants to merge 2 commits into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Sep 12, 2024

🔍 Description

Issue References 🔗

To close #6686

image

The pod already in failed state, and the driver container is in waiting state.

We shall mark the application terminated and ignore the container state.

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@turboFei turboFei changed the title [KYUUBI #6686] Check whether pod based application state terminated [KYUUBI #6686] Mark application terminated if pod is terminated Sep 12, 2024
@turboFei turboFei self-assigned this Sep 12, 2024
@turboFei turboFei changed the title [KYUUBI #6686] Mark application terminated if pod is terminated [KYUUBI #6686] Ignore container state if pod is terminated Sep 12, 2024
@turboFei turboFei changed the title [KYUUBI #6686] Ignore container state if pod is terminated [KYUUBI #6686] Ignore Spark pod container state if pod is terminated Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (db5ce0c) to head (0d4c8a2).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...kyuubi/engine/KubernetesApplicationOperation.scala 0.00% 15 Missing ⚠️
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6690   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         684     684           
  Lines       42233   42244   +11     
  Branches     5755    5756    +1     
======================================
- Misses      42233   42244   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turboFei turboFei closed this in f8431da Sep 14, 2024
@turboFei turboFei added this to the v1.10.0 milestone Sep 14, 2024
@turboFei turboFei deleted the pod_state branch September 14, 2024 19:28
@turboFei
Copy link
Member Author

thanks, merged to 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Kyuubi batch state abnormal - batch failed but marked as finished
4 participants