Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude transitive deps of paimon #6698

Closed
wants to merge 1 commit into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Sep 17, 2024

🔍 Description

Issue References 🔗

paimon-spark-3.5 is a bundled jar but still pulls transitive deps.

Describe Your Solution 🔧

Explicitly excluding transitive deps of paimon.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Pass GHA and manually checked.


Checklist 📝

Be nice. Be informative.

@pan3793 pan3793 changed the title Exclude transitive deps from paimon Exclude transitive deps of paimon Sep 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (8e2b1b3) to head (6048b11).
Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6698   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         684     684           
  Lines       42279   42279           
  Branches     5765    5765           
======================================
  Misses      42279   42279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 closed this in 635c793 Sep 18, 2024
pan3793 added a commit that referenced this pull request Sep 18, 2024
# 🔍 Description
## Issue References 🔗

`paimon-spark-3.5` is a bundled jar but still pulls transitive deps.

## Describe Your Solution 🔧

Explicitly excluding transitive deps of paimon.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Pass GHA and manually checked.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6698 from pan3793/exclude-paimon.

Closes #6698

6048b11 [Cheng Pan] Exclude transitive deps from paimon

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 635c793)
Signed-off-by: Cheng Pan <[email protected]>
@pan3793 pan3793 self-assigned this Sep 18, 2024
@pan3793 pan3793 added this to the v1.9.3 milestone Sep 18, 2024
@pan3793
Copy link
Member Author

pan3793 commented Sep 18, 2024

Thanks, merged to master/1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants