-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #6843] Fix 'query-timeout-thread' thread leak #6844
base: master
Are you sure you want to change the base?
Conversation
Please fix the failed checks. |
@ASiegeLion please write the PR description seriously, and revert unnecessary code changes. |
ok |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6844 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42463 42467 +4
Branches 5796 5796
======================================
- Misses 42463 42467 +4 ☔ View full report in Codecov by Sentry. |
We also fixed this issue a few months ago. cc @lsm1 |
@ASiegeLion In other engines, there might be the same issue. Please fix it. |
Why are the changes needed?
see #6843
If the session manager's ThreadPoolExecutor refuses to execute asyncOperation, then we need to shut down the query-timeout-thread in the catch
How was this patch tested?
1 Use jstack to view threads on the long-lived engine side
2 Wait for all SQL statements in the engine to finish executing, and then use stack to check the number of query-timeout-thread threads, which should be empty.
Was this patch authored or co-authored using generative AI tooling?
NO