Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-4674][feat] update jdbc and trino ec properties #4676

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

lenoxzhao
Copy link
Contributor

@lenoxzhao lenoxzhao commented Jun 19, 2023

What is the purpose of the change

Add jdbc and trino engine does not exit configuration parameter by default.

Related issues/PRs

Related issues: #4674

Brief change log

  • add wds.linkis.engineconn.max.free.time=0 to linkis-engineconn.properties.

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@lenoxzhao lenoxzhao closed this Jun 19, 2023
@lenoxzhao lenoxzhao reopened this Jun 19, 2023
@casionone
Copy link
Contributor

LGTM

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 4985e0b into apache:dev-1.4.0 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants