Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] add kanban in linkisweb #5089

Merged
merged 14 commits into from
Mar 13, 2024
Merged

[FEATURE] add kanban in linkisweb #5089

merged 14 commits into from
Mar 13, 2024

Conversation

sjgllgh
Copy link
Contributor

@sjgllgh sjgllgh commented Feb 22, 2024 •
edited
Loading

What is the purpose of the change

Add statistical analysis dashboards for task execution status.

  • Added task execution status statistics (Data Source: Table linkis_ps_job_history_group_history)
  • Added engine startup status statistics (Data Source: Table linkis_cg_ec_resource_info_record)
  • Added top N list of task duration (Data Source: Table linkis_ps_job_history_group_history)

为任务执行情况增加统计分析看板

  • 增加了任务执行情况统计 (Data Source: Table linkis_ps_job_history_group_history)
  • 增加了引擎启动情况统计 (Data Source: Table linkis_cg_ec_resource_info_record)
  • 增加了任务耗时TOPN列表 (Data Source: Table linkis_ps_job_history_group_history)

Related issues/PRs

Related issues: #4189

Pictures

sample

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • [] I have added tests corresponding to this change
  • [] I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

aiceflower
aiceflower reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@aiceflower aiceflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mayinrain
mayinrain reviewed Feb 22, 2024
View reviewed changes
linkis-web/src/apps/linkis/module/statisticsDashboard/index.vue Outdated
import api from '@/common/service/api'
var echarts = require('echarts')
export default {
name: 'GlobalHistory',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be named StatisticsDashBoard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. I have made modifications to this content.

linkis-web/package.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for changes here, let's keep the whitespace consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the component of echarts is used, so the modification here is necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, what I mean is that due to inconsistent indentation, some areas that should not be modified have been modified. This may be an issue with inconsistent editor formatting configuration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misunderstood your intention. I will confirm why this problem occurred.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. I have made modifications to this content.

linkis-web/src/apps/linkis/i18n/common/zh.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is the same as in package.json; try not to make changes to other parts of the file due to formatting issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because some new content has been added and internationalization adaptation is required for this part, the modifications here are necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. I have made modifications to this content.

@mayinrain
Copy link
Contributor

LGTM.

peacewong
peacewong approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit c8f9537 into apache:master Mar 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiceflower aiceflower aiceflower left review comments

@mayinrain mayinrain mayinrain left review comments

@peacewong peacewong peacewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sjgllgh @mayinrain @peacewong @aiceflower