Support resultSet direct push for SparkSqlExecutor #5170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peacewong
reviewed
Sep 13, 2024
| val vector = new VarCharVector(field.name, allocator) | ||
| vector.allocateNew(df.count().toInt) | ||
| vector | ||
| case _ => throw new IllegalArgumentException(s"Unsupported data type: ${field.dataType}") |
There was a problem hiding this comment.
Are other types not supported? Can we convert to String by default if the type is not supported ?
There was a problem hiding this comment.
You're right, I will improve this part.
…re not used for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using direct push of result sets, data does not need to be cached on disk and can be calculated in real-time and returned directly from memory. This PR supports direct pushing of resultSets under SparkSqlExecutor.