Skip to content

Commit

Permalink
Make SegmentInfos#readCommit(Directory, String, int) public (#14027)
Browse files Browse the repository at this point in the history
The corresponding readLatestCommit method is public and can be used to
read segment infos from indices that are older than N - 1.
The same should be possible for readCommit, but that requires the method
that takes the minimum supported version as an argument to be public.
  • Loading branch information
javanna authored Dec 2, 2024
1 parent a248306 commit a6f9bde
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
2 changes: 2 additions & 0 deletions lucene/CHANGES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@ Bug Fixes
* GITHUB#13990: Added filter to the toString() method of Knn[Float|Byte]VectorQuery
and DiversifyingChildren[Float|Byte]KnnVectorQuery. (Viswanath Kuchibhotla)

* GITHUB#14027: Make SegmentInfos#readCommit(Directory, String, int) public

Build
---------------------

Expand Down
11 changes: 9 additions & 2 deletions lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,14 @@ public static final SegmentInfos readCommit(Directory directory, String segmentF
return readCommit(directory, segmentFileName, Version.MIN_SUPPORTED_MAJOR);
}

static final SegmentInfos readCommit(
/**
* Read a particular segmentFileName, as long as the commit's {@link
* SegmentInfos#getIndexCreatedVersionMajor()} is strictly greater than the provided minimum
* supported major version. If the commit's version is older, an {@link
* IndexFormatTooOldException} will be thrown. Note that this may throw an IOException if a commit
* is in process.
*/
public static final SegmentInfos readCommit(
Directory directory, String segmentFileName, int minSupportedMajorVersion)
throws IOException {

Expand All @@ -307,7 +314,7 @@ public static final SegmentInfos readCommit(
}

/** Read the commit from the provided {@link ChecksumIndexInput}. */
static final SegmentInfos readCommit(
public static final SegmentInfos readCommit(
Directory directory, ChecksumIndexInput input, long generation, int minSupportedMajorVersion)
throws IOException {
Throwable priorE = null;
Expand Down

0 comments on commit a6f9bde

Please sign in to comment.