Backport #13202 to branch_9x #13295
Closed
Backport #13202 to branch_9x #13295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vigyasharma
commented
Apr 11, 2024
vigyasharma
commented
- Add timeout support to AbstractKnnVectorQuery (Add timeout support to AbstractKnnVectorQuery #13202)
- Fix failing BaseKnnVectorQueryTestCase#testTimeout (Fix failing BaseKnnVectorQueryTestCase#testTimeout #13283)
* Add timeout support to graph searches in AbstractKnnVectorQuery * Also timeout exact searches * Return partial KNN results * Add tests for partial KNN results - Refactor tests to base classes - Also timeout exact searches in Lucene99HnswVectorsReader * Add CHANGES.txt entry and fix some comments --------- Co-authored-by: Kaival Parikh <[email protected]>
* Fix failing BaseKnnVectorQueryTestCase#testTimeout * Also fix ParentBlockJoinKnnVectorQueryTestCase#testTimeout --------- Co-authored-by: Kaival Parikh <[email protected]>
|
Now that the test failure have been fixed, I'm backporting #13202 to |
|
Getting the same test failure here. > Task :lucene:core:compileTestJava
/home/runner/work/lucene/lucene/lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:816: error: cannot find symbol
noTimeoutManager.newCollector(Integer.MAX_VALUE, searcher.leafContexts.getFirst());
^
symbol: method getFirst()
location: variable leafContexts of type List<LeafReaderContext>
/home/runner/work/lucene/lucene/lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java:832: error: cannot find symbol
timeoutManager.newCollector(Integer.MAX_VALUE, searcher.leafContexts.getFirst());
^
symbol: method getFirst()
location: variable leafContexts of type List<LeafReaderContext>
Note: Some input files use or override a deprecated API. |
benwtrent
reviewed
Apr 11, 2024
| TimeLimitingKnnCollectorManager noTimeoutManager = | ||
| new TimeLimitingKnnCollectorManager(delegate, null); | ||
| KnnCollector noTimeoutCollector = | ||
| noTimeoutManager.newCollector(Integer.MAX_VALUE, searcher.leafContexts.getFirst()); |
There was a problem hiding this comment.
Pretty sure getFirst is a JDK21+ only thing. The compilation level on branch_9x is too low to allow that API.
|
Backported changes directly to retain original commit messages. This PR would've needed a squash merge as it was not rebased on the latest branch_9x commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.