Compare the missing value with the top value even after the hit queue is full #13644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I left you one comment in the corresponding issue you opened for this (sorry, meant to put it here in the PR). |
bugmakerrrrrr
force-pushed
the
after_with_missing
branch
from
680b0e2
to
9271d09
Compare
|
Looks good. Thanks @bugmakerrrrrr! (Looks like the check task failed in a transient way... out of disk space? I ran the checks locally just to make sure they pass and they do, as expected) |
|
@bugmakerrrrrr could you add an entry in CHANGES.txt before we merge please? |
bugmakerrrrrr
force-pushed
the
after_with_missing
branch
from
9271d09
to
499616f
Compare
|
@gsmiller I add the entry under 9.12.0 Optimizations, please correct me if I'm wrong. |
|
Sounds right to me. Thanks @bugmakerrrrrr ! |
gsmiller
approved these changes
Aug 14, 2024
gsmiller
pushed a commit
that referenced
this pull request
Aug 14, 2024
original-brownbear
added a commit
to original-brownbear/lucene
that referenced
this pull request
Sep 30, 2024
…it queue is full (apache#13644)" This reverts commit 7cd2eb2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see #13643