Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for .NET support #992

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Updates the .NET support information in the README.

Related to #928

Description

Updates the README to add the .NET 8 target, specify that the CLI requires the .NET 8 runtime, and removes references to older unsupported frameworks.

Updates the README to add the .NET 8 target, specify that the CLI requires the .NET 8 runtime, and removes references to older unsupported frameworks.
Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I left an inline comment.

Please do not merge this to master until after the 4.8.0-beta00017 release.

@@ -37,9 +38,9 @@ Working toward Lucene.NET 4.8.0 (currently in BETA)

* The beta version is extremely stable
* Has more than 7800+ passing unit tests
* Integrates well with .NET 6.0, .NET 5.0 and .NET Core 2+
* Integrates well with .NET 8.0 and .NET 6.0 (as well as other unsupported versions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just reading a comment yesterday that I left about this. This tends to go out of date faster than we can update it. So, maybe we should just say something along the lines of "Tested daily on all officially supported versions of .NET Core".

The targets have a loose relationship with the runtimes, but I suspect anyone reading this just wants to know if their preferred runtime will work. If anyone wants to see our supported target frameworks, it is all on the NuGet package page. Maybe we should just drop a link to: https://www.nuget.org/packages/Lucene.Net/absoluteLatest#supportedframeworks-body-tab, which will always be up to date.

Also, this information was copied over to our homepage, which will also need to be updated: https://lucenenet.apache.org/. At one point, these 2 descriptions were identical, but they don't remain in sync because they don't share the same source file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants