[MNG-2961] Remove workaround for fixed bug (#441)

* Remove workaround for fixed bug
apache · Oct 19, 2024 · 15a3f52 · 15a3f52
1 parent 6da7a1d
commit 15a3f52
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java b/src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
@@ -502,9 +502,6 @@ private void writeDependencyXML(Set<Artifact> artifacts) {
             PrettyPrintXMLWriter writer = new PrettyPrintXMLWriter(out);
 
             for (Artifact artifact : artifacts) {
-                // called because artifact will set the version to -SNAPSHOT only if I do this. MNG-2961
-                artifact.isSnapshot();
-
                 writer.startElement("dependency");
                 writer.startElement("groupId");
                 writer.writeText(artifact.getGroupId());

diff --git a/src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDepMgt.java b/src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDepMgt.java
@@ -212,9 +212,9 @@ public String getExclusionKey(Exclusion ex) {
     /**
      * Calculate the mismatches between the DependencyManagement and resolved artifacts
      *
-     * @param depMgtMap contains the Dependency.GetManagementKey as the keyset for quick lookup.
-     * @param allDependencyArtifacts contains the set of all artifacts to compare.
-     * @return a map containing the resolved artifact as the key and the listed dependency as the value.
+     * @param depMgtMap a keyset of the Dependency.GetManagementKey for quick lookup
+     * @param allDependencyArtifacts the set of all artifacts to compare
+     * @return a map containing the resolved artifact as the key and the listed dependency as the value
      */
     public Map<Artifact, Dependency> getMismatch(
             Map<String, Dependency> depMgtMap, Set<Artifact> allDependencyArtifacts) {
@@ -223,9 +223,6 @@ public Map<Artifact, Dependency> getMismatch(
         for (Artifact dependencyArtifact : allDependencyArtifacts) {
             Dependency depFromDepMgt = depMgtMap.get(getArtifactManagementKey(dependencyArtifact));
             if (depFromDepMgt != null) {
-                // workaround for MNG-2961
-                dependencyArtifact.isSnapshot();
-
                 if (depFromDepMgt.getVersion() != null
                         && !depFromDepMgt.getVersion().equals(dependencyArtifact.getBaseVersion())) {
                     mismatchMap.put(dependencyArtifact, depFromDepMgt);