Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 20 to 21 #346

Closed
wants to merge 2 commits into from
Closed

JDK 20 to 21 #346

wants to merge 2 commits into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Oct 22, 2023

No description provided.

JDK 21 is now both the latest and latest longterm release so test against it. Worth noting: I've seen some other open source projects have unexpected test failures due to changes in this release.
@elharo elharo requested a review from slachiewicz October 22, 2023 13:15
@elharo
Copy link
Contributor Author

elharo commented Oct 22, 2023

Looks like this plugin does have a JDK 21 issue:

Caused by: org.apache.maven.plugin.PluginContainerException: An API incompatibility was encountered while executing com.diffplug.spotless:spotless-maven-plugin:2.37.0:check: java.lang.NoSuchMethodError: 'com.sun.tools.javac.tree.JCTree com.sun.tools.javac.tree.JCTree$JCImport.getQualifiedIdentifier()'

@elharo
Copy link
Contributor Author

elharo commented Oct 22, 2023

Or rather spotless does

@slachiewicz
Copy link
Member

Never version of the spotless plugin requires Java 11

@slawekjaranowski
Copy link
Member

suppressed by #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants