[MJLINK-79] addOptions should not quote option strings (#196)

* [MJLINK-79] addOptions should not quote option strings * Fix testcase for --add-options
apache · Dec 2, 2024 · a4f35a5 · a4f35a5
1 parent 022d9e5
commit a4f35a5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/it/projects/cli-options/add-options/verify.groovy b/src/it/projects/cli-options/add-options/verify.groovy
@@ -24,7 +24,7 @@ import java.util.jar.*
 import org.codehaus.plexus.util.*
 
 String buildlog = new File( basedir, "build.log").text
-assert buildlog.contains( "--add-options, \"-Xmx128m --enable-preview -Dvar=value\"" )
+assert buildlog.contains( "--add-options, -Xmx128m --enable-preview -Dvar=value" )
 assert buildlog.contains( "addOptions = [-Xmx128m, --enable-preview, -Dvar=value]" )
 
 File target = new File( basedir, "target" )

diff --git a/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java b/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
@@ -682,7 +682,7 @@ protected List<String> createJlinkArgs(Collection<String> pathsOfModules, Collec
         }
         if (addOptions != null && !addOptions.isEmpty()) {
             jlinkArgs.add("--add-options");
-            jlinkArgs.add(String.format("\"%s\"", String.join(" ", addOptions)));
+            jlinkArgs.add(String.join(" ", addOptions));
         }
 
         if (disablePlugin != null) {