Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace two deprecated methods #224

Merged
merged 3 commits into from
Dec 7, 2024
Merged

Replace two deprecated methods #224

merged 3 commits into from
Dec 7, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Dec 2, 2024

No description provided.

@elharo elharo marked this pull request as ready for review December 2, 2024 20:04
@elharo
Copy link
Contributor Author

elharo commented Dec 3, 2024

Possible windows build is broken; need to investigate and might nee d to roll a recently merged PR back:

Error:  org.apache.maven.plugins.jlink.JLinkMojoTest.single_quotes_shell_command -- Time elapsed: 0.063 s <<< FAILURE!
org.opentest4j.AssertionFailedError: 

expected: "/bin/sh -c '/path/to/jlink "--strip-debug" "--module-path" "foo:bar" "--add-modules" "mvn,jlink"'"
 but was: "cmd.exe /X /C ""D:\path\to\jlink "--strip-debug" "--module-path" "foo;bar" "--add-modules" "mvn,jlink""""
	at org.apache.maven.plugins.jlink.JLinkMojoTest.single_quotes_shell_command(JLinkMojoTest.java:61)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

[INFO] Running org.apache.maven.plugins.jlink.MultipleLauncherTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 s -- in org.apache.maven.plugins.jlink.MultipleLauncherTest
[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    JLinkMojoTest.single_quotes_shell_command:61 
expected: "/bin/sh -c '/path/to/jlink "--strip-debug" "--module-path" "foo:bar" "--add-modules" "mvn,jlink"'"
 but was: "cmd.exe /X /C ""D:\path\to\jlink "--strip-debug" "--module-path" "foo;bar" "--add-modules" "mvn,jlink""""
[INFO] 

@elharo elharo merged commit 235a5de into master Dec 7, 2024
52 checks passed
@elharo elharo deleted the depre branch December 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants