[MRESOLVER-386] Make all injected ctors public, deprecate def ctors

All injection points are public and deprecate all def ctors (where ctor injection used).

---

https://issues.apache.org/jira/browse/MRESOLVER-386

maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java

@@ -63,12 +63,13 @@ public final class BasicRepositoryConnectorFactory implements RepositoryConnecto
      * clients, the new factory needs to be configured via its various mutators before first use or runtime errors will
      * occur.
      */
+    @Deprecated
     public BasicRepositoryConnectorFactory() {
         // enables default constructor
     }
 
     @Inject
-    BasicRepositoryConnectorFactory(
+    public BasicRepositoryConnectorFactory(
             TransporterProvider transporterProvider,
             RepositoryLayoutProvider layoutProvider,
             ChecksumPolicyProvider checksumPolicyProvider,

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java

@@ -125,13 +125,14 @@ public class DefaultArtifactResolver implements ArtifactResolver, Service {
 
     private RemoteRepositoryFilterManager remoteRepositoryFilterManager;
 
+    @Deprecated
     public DefaultArtifactResolver() {
         // enables default constructor
     }
 
     @SuppressWarnings("checkstyle:parameternumber")
     @Inject
-    DefaultArtifactResolver(
+    public DefaultArtifactResolver(
             FileProcessor fileProcessor,
             RepositoryEventDispatcher repositoryEventDispatcher,
             VersionResolver versionResolver,

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java

@@ -97,13 +97,14 @@ public class DefaultDeployer implements Deployer, Service {
 
     private OfflineController offlineController;
 
+    @Deprecated
     public DefaultDeployer() {
         // enables default constructor
     }
 
     @SuppressWarnings("checkstyle:parameternumber")
     @Inject
-    DefaultDeployer(
+    public DefaultDeployer(
             FileProcessor fileProcessor,
             RepositoryEventDispatcher repositoryEventDispatcher,
             RepositoryConnectorProvider repositoryConnectorProvider,

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java

@@ -75,12 +75,13 @@ public class DefaultInstaller implements Installer, Service {
 
     private SyncContextFactory syncContextFactory;
 
+    @Deprecated
     public DefaultInstaller() {
         // enables default constructor
     }
 
     @Inject
-    DefaultInstaller(
+    public DefaultInstaller(
             FileProcessor fileProcessor,
             RepositoryEventDispatcher repositoryEventDispatcher,
             Set<MetadataGeneratorFactory> metadataFactories,

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultLocalRepositoryProvider.java

@@ -50,12 +50,13 @@ public class DefaultLocalRepositoryProvider implements LocalRepositoryProvider,
 
     private Collection<LocalRepositoryManagerFactory> managerFactories = new ArrayList<>();
 
+    @Deprecated
     public DefaultLocalRepositoryProvider() {
         // enables default constructor
     }
 
     @Inject
-    DefaultLocalRepositoryProvider(Set<LocalRepositoryManagerFactory> factories) {
+    public DefaultLocalRepositoryProvider(Set<LocalRepositoryManagerFactory> factories) {
         setLocalRepositoryManagerFactories(factories);
     }
 

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java

@@ -92,12 +92,13 @@ public class DefaultMetadataResolver implements MetadataResolver, Service {
 
     private RemoteRepositoryFilterManager remoteRepositoryFilterManager;
 
+    @Deprecated
     public DefaultMetadataResolver() {
         // enables default constructor
     }
 
     @Inject
-    DefaultMetadataResolver(
+    public DefaultMetadataResolver(
             RepositoryEventDispatcher repositoryEventDispatcher,
             UpdateCheckManager updateCheckManager,
             RepositoryConnectorProvider repositoryConnectorProvider,

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRemoteRepositoryManager.java

@@ -83,12 +83,13 @@ public int hashCode() {
 
     private ChecksumPolicyProvider checksumPolicyProvider;
 
+    @Deprecated
     public DefaultRemoteRepositoryManager() {
         // enables default constructor
     }
 
     @Inject
-    DefaultRemoteRepositoryManager(
+    public DefaultRemoteRepositoryManager(
             UpdatePolicyAnalyzer updatePolicyAnalyzer, ChecksumPolicyProvider checksumPolicyProvider) {
         setUpdatePolicyAnalyzer(updatePolicyAnalyzer);
         setChecksumPolicyProvider(checksumPolicyProvider);

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java

@@ -57,12 +57,13 @@ public class DefaultRepositoryConnectorProvider implements RepositoryConnectorPr
 
     private RemoteRepositoryFilterManager remoteRepositoryFilterManager;
 
+    @Deprecated
     public DefaultRepositoryConnectorProvider() {
         // enables default constructor
     }
 
     @Inject
-    DefaultRepositoryConnectorProvider(
+    public DefaultRepositoryConnectorProvider(
             Set<RepositoryConnectorFactory> connectorFactories,
             RemoteRepositoryFilterManager remoteRepositoryFilterManager) {
         setRepositoryConnectorFactories(connectorFactories);

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryEventDispatcher.java

@@ -46,12 +46,13 @@ public class DefaultRepositoryEventDispatcher implements RepositoryEventDispatch
 
     private Collection<RepositoryListener> listeners = new ArrayList<>();
 
+    @Deprecated
     public DefaultRepositoryEventDispatcher() {
         // enables no-arg constructor
     }
 
     @Inject
-    DefaultRepositoryEventDispatcher(Set<RepositoryListener> listeners) {
+    public DefaultRepositoryEventDispatcher(Set<RepositoryListener> listeners) {
         setRepositoryListeners(listeners);
     }
 

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryLayoutProvider.java

@@ -50,12 +50,13 @@ public final class DefaultRepositoryLayoutProvider implements RepositoryLayoutPr
 
     private Collection<RepositoryLayoutFactory> factories = new ArrayList<>();
 
+    @Deprecated
     public DefaultRepositoryLayoutProvider() {
         // enables default constructor
     }
 
     @Inject
-    DefaultRepositoryLayoutProvider(Set<RepositoryLayoutFactory> layoutFactories) {
+    public DefaultRepositoryLayoutProvider(Set<RepositoryLayoutFactory> layoutFactories) {
         setRepositoryLayoutFactories(layoutFactories);
     }
 

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java

@@ -117,14 +117,15 @@ public class DefaultRepositorySystem implements RepositorySystem, Service {
 
     private RepositorySystemLifecycle repositorySystemLifecycle;
 
+    @Deprecated
     public DefaultRepositorySystem() {
         // enables default constructor
         this.shutdown = new AtomicBoolean(false);
     }
 
     @SuppressWarnings("checkstyle:parameternumber")
     @Inject
-    DefaultRepositorySystem(
+    public DefaultRepositorySystem(
             VersionResolver versionResolver,
             VersionRangeResolver versionRangeResolver,
             ArtifactResolver artifactResolver,

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTransporterProvider.java

@@ -50,12 +50,13 @@ public final class DefaultTransporterProvider implements TransporterProvider, Se
 
     private Collection<TransporterFactory> factories = new ArrayList<>();
 
+    @Deprecated
     public DefaultTransporterProvider() {
         // enables default constructor
     }
 
     @Inject
-    DefaultTransporterProvider(Set<TransporterFactory> transporterFactories) {
+    public DefaultTransporterProvider(Set<TransporterFactory> transporterFactories) {
         setTransporterFactories(transporterFactories);
     }
 

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java

@@ -106,12 +106,13 @@ public String toString() {
      */
     private static final long TS_UNKNOWN = 1L;
 
+    @Deprecated
     public DefaultUpdateCheckManager() {
         // default ctor for ServiceLocator
     }
 
     @Inject
-    DefaultUpdateCheckManager(TrackingFileManager trackingFileManager, UpdatePolicyAnalyzer updatePolicyAnalyzer) {
+    public DefaultUpdateCheckManager(TrackingFileManager trackingFileManager, UpdatePolicyAnalyzer updatePolicyAnalyzer) {
         setTrackingFileManager(trackingFileManager);
         setUpdatePolicyAnalyzer(updatePolicyAnalyzer);
     }

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/EnhancedLocalRepositoryManagerFactory.java

@@ -55,6 +55,7 @@ public class EnhancedLocalRepositoryManagerFactory implements LocalRepositoryMan
 
     private LocalPathPrefixComposerFactory localPathPrefixComposerFactory;
 
+    @Deprecated
     public EnhancedLocalRepositoryManagerFactory() {
         // no arg ctor for ServiceLocator
     }

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SimpleLocalRepositoryManagerFactory.java

@@ -42,6 +42,7 @@ public class SimpleLocalRepositoryManagerFactory implements LocalRepositoryManag
 
     private LocalPathComposer localPathComposer;
 
+    @Deprecated
     public SimpleLocalRepositoryManagerFactory() {
         // enable no-arg constructor
         this.localPathComposer = new DefaultLocalPathComposer(); // maven UTs needs this

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java

@@ -121,7 +121,7 @@ public BfDependencyCollector() {
     }
 
     @Inject
-    BfDependencyCollector(
+    public BfDependencyCollector(
             RemoteRepositoryManager remoteRepositoryManager,
             ArtifactDescriptorReader artifactDescriptorReader,
             VersionRangeResolver versionRangeResolver) {

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/df/DfDependencyCollector.java

@@ -79,7 +79,7 @@ public DfDependencyCollector() {
     }
 
     @Inject
-    DfDependencyCollector(
+    public DfDependencyCollector(
             RemoteRepositoryManager remoteRepositoryManager,
             ArtifactDescriptorReader artifactDescriptorReader,
             VersionRangeResolver versionRangeResolver) {

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/legacy/DefaultSyncContextFactory.java

@@ -43,6 +43,7 @@
 public final class DefaultSyncContextFactory implements org.eclipse.aether.impl.SyncContextFactory, Service {
     private SyncContextFactory delegate;
 
+    @Deprecated
     public DefaultSyncContextFactory() {
         // default ctor for ServiceLocator
     }

maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/transport/wagon/WagonTransporterFactory.java

@@ -50,6 +50,7 @@ public final class WagonTransporterFactory implements TransporterFactory, Servic
      * by clients, the new factory needs to be configured via its various mutators before first use or runtime errors
      * will occur.
      */
+    @Deprecated
     public WagonTransporterFactory() {
         // enables default constructor
     }