Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-376] UT for bug #312

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jun 30, 2023

This UT on master makes old DF work, while BF break with SOError.

If same UT ran on fixed branch, both pass.

Still, seems combo of range+relocation has some other issues as well, as all this works only partially, as the range is not resolved, only first applicant (lowest version in DF and highest version in BF as it sort-reverse the versions). This may be UT support class issue as well, unsure.


https://issues.apache.org/jira/browse/MRESOLVER-376

This UT on master makes old DF work, while BF break with SOEx.

If same UT ran on fixed branch, both pass.

Still, seems combo of range+relocation has some other issues as well,
as all this works only partially, as the range is not resolved,
only first applicant (lowest version in DF and highest version
in BF as it sort-reverse the versions).

---

https://issues.apache.org/jira/browse/MRESOLVER-376
@cstamas cstamas self-assigned this Jun 30, 2023
@cstamas
Copy link
Member Author

cstamas commented Jun 30, 2023

@caiwei-ebay ping

@cstamas
Copy link
Member Author

cstamas commented Jun 30, 2023

Here is UT failure (same stack trace as in issue):

[INFO] Running org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollectorTest
Error:  Tests run: 42, Failures: 0, Errors: 2, Skipped: 1, Time elapsed: 0.346 s <<< FAILURE! - in org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollectorTest
Error:  org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollectorTest.testTransitiveDepsUseRangesAndRelocationDirtyTree[0]  Time elapsed: 0.023 s  <<< ERROR!
java.lang.StackOverflowError
	at java.base/java.lang.StringBuilder.<init>(StringBuilder.java:119)
	at org.eclipse.aether.util.artifact.ArtifactIdUtils.concat(ArtifactIdUtils.java:123)
	at org.eclipse.aether.util.artifact.ArtifactIdUtils.toId(ArtifactIdUtils.java:66)
	at org.eclipse.aether.util.artifact.ArtifactIdUtils.toId(ArtifactIdUtils.java:45)
	at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector$ParallelDescriptorResolver.find(BfDependencyCollector.java:500)
	at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.processDependency(BfDependencyCollector.java:215)
	at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.processDependency(BfDependencyCollector.java:271)
	at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.processDependency(BfDependencyCollector.java:271)
	at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.processDependency(BfDependencyCollector.java:271)
	at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.processDependency(BfDependencyCollector.java:271)
	at org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.processDependency(BfDependencyCollector.java:271)

@cstamas
Copy link
Member Author

cstamas commented Jun 30, 2023

Created bug to examing range+redirect case https://issues.apache.org/jira/browse/MRESOLVER-379

@cstamas cstamas added this to the 1.9.14 milestone Jun 30, 2023
@cstamas cstamas merged commit d9d2370 into apache:master Jul 19, 2023
1 of 2 checks passed
@cstamas cstamas deleted the MRESOLVER-376-ut branch July 19, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant