Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Julia: add windows-cpu build #13937

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Julia: add windows-cpu build #13937

merged 1 commit into from
Jan 23, 2019

Conversation

iblislin
Copy link
Member

@iblislin iblislin commented Jan 20, 2019

  • Julia v0.7
  • Julia v1.0

@iblislin iblislin added CI Julia pr-work-in-progress PR is still work in progress labels Jan 20, 2019
@iblislin iblislin requested a review from marcoabreu as a code owner January 20, 2019 02:06
@iblislin
Copy link
Member Author

@marcoabreu
Copy link
Contributor

marcoabreu commented Jan 20, 2019

Yeah Powershell is not very smart unfortunately :( Have a look at how we do it here: https://github.com/apache/incubator-mxnet/blob/e8a2b8b9fdafaccbf65397cec142fffcae2289b7/ci/windows/test_py3_cpu.ps1#L27

What this basically does is evaluating the previous return code and then manually throwing an exception. I think there's no way to have a set -e like we have in bash...

@marcoabreu
Copy link
Contributor

Btw here's the RFC to add native error handling to Powershell. Feel free to give it a +1 PowerShell/PowerShell-RFC#88

@iblislin iblislin changed the title WIP: Julia: add windows-cpu build Julia: add windows-cpu build Jan 21, 2019
@iblislin iblislin added pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels Jan 21, 2019
@iblislin
Copy link
Member Author

This PR is ready for review.

@marcoabreu
Copy link
Contributor

Could you elaborate that's the deal with

powershell.exe : [ Info: Path `C:\jenkins_slave\workspace\ut-julia07-cpu\julia-depot\dev\MXNet` exists and looks like the correct package, using existing path instead of cloning

At C:\jenkins_slave\workspace\ut-julia07-cpu@tmp\durable-9d0a0ccf\powershellWrapper.ps1:3 char:1

+ & powershell -NoProfile -NonInteractive -ExecutionPolicy Bypass -Comm ...

+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    + CategoryInfo          : NotSpecified: ([ Info: Path `C...tead of cloning    :String) [], RemoteException

    + FullyQualifiedErrorId : NativeCommandError

It's flagged as an error, doesn't seem like one and isn't handled like one.

@iblislin
Copy link
Member Author

Still not sure which line causes that message.
Will get a windows machine to figure out it later.

@iblislin iblislin changed the title Julia: add windows-cpu build WIP: Julia: add windows-cpu build Jan 22, 2019
@iblislin iblislin added pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review labels Jan 22, 2019
@iblislin iblislin requested a review from szha as a code owner January 22, 2019 12:03
@iblislin iblislin changed the title WIP: Julia: add windows-cpu build Julia: add windows-cpu build Jan 22, 2019
@iblislin iblislin added pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels Jan 22, 2019
Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for iterating on this!

Besides the nit about the comment, good to ship from my side.

@iblislin iblislin closed this Jan 23, 2019
@iblislin iblislin reopened this Jan 23, 2019
- Julia v0.7
- Julia v1.0
@lebeg
Copy link
Contributor

lebeg commented Jan 23, 2019

Looks good, only 4 and 5 minutes for the testing parts

@iblislin iblislin merged commit ce8b083 into master Jan 23, 2019
@iblislin iblislin deleted the ib/ci-jl-win branch January 23, 2019 15:46
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Jan 27, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI Julia pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants