-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
iblislin
commented
Jan 20, 2019
•
edited
Loading
edited
- Julia v0.7
- Julia v1.0
well, why errors in powershell script are not considered as build failure? |
Yeah Powershell is not very smart unfortunately :( Have a look at how we do it here: https://github.com/apache/incubator-mxnet/blob/e8a2b8b9fdafaccbf65397cec142fffcae2289b7/ci/windows/test_py3_cpu.ps1#L27 What this basically does is evaluating the previous return code and then manually throwing an exception. I think there's no way to have a |
Btw here's the RFC to add native error handling to Powershell. Feel free to give it a +1 PowerShell/PowerShell-RFC#88 |
b2a4efc
to
298b6ec
Compare
This PR is ready for review. |
Could you elaborate that's the deal with
It's flagged as an error, doesn't seem like one and isn't handled like one. |
Still not sure which line causes that message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for iterating on this!
Besides the nit about the comment, good to ship from my side.
- Julia v0.7 - Julia v1.0
71ac27e
to
6161e84
Compare
Looks good, only 4 and 5 minutes for the testing parts |
- Julia v0.7 - Julia v1.0
- Julia v0.7 - Julia v1.0
- Julia v0.7 - Julia v1.0