nimble/transport: Add common HCI RX task #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-kaczmarek
force-pushed
the
transport-rx-task
branch
7 times, most recently
from
caaa1cb
to
23b9324
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| static void | ||
| rx_task_func(void *arg) |
Check notice
Code scanning / CodeQL
Unused static function Note
sjanc
approved these changes
Oct 31, 2023
|
is it still needed? @andrzej-kaczmarek |
This adds common syscfg that is defined when monitor is used.
This adds common task for implementing HCI RX. Any transport can simply register its own function for RX that will be run in separate task whenever triggered by dedicated API. This for example allows to easily implement handling HCI RX in a task instead of in an interrupt since handling RX in an interrupt doesn't work well with monitor enabled. If selected transport doesn't register its function, all rx_task code will be compiled out since there won't be any references to that code.
This adds option to move RX from interrupt to task. This is enforced if monitor is used since montor code cannot be used from interrupts.
andrzej-kaczmarek
force-pushed
the
transport-rx-task
branch
from
23b9324
to
888d531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds common task for implementing HCI RX. Any transport can simply
register its own function for RX that will be run in separate task
whenever triggered by dedicated API. This for example allows to easily
implement handling HCI RX in a task instead of in an interrupt since
handling RX in an interrupt doesn't work well with monitor enabled.
If selected transport doesn't register its function, all rx_task code
will be compiled out since there won't be any references to that code.