controller: fix ISO compilation errors when build for Broadcast only, and for nRF52 #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKopyscinski
force-pushed
the
iso_compile_fix
branch
3 times, most recently
from
fa17859
to
daf259a
Compare
nimble/controller/src/ble_ll_hci.c
Outdated
| @@ -1503,7 +1503,8 @@ ble_ll_hci_ctlr_bb_cmd_proc(const uint8_t *cmdbuf, uint8_t len, uint16_t ocf, | |||
| case BLE_HCI_OCF_CB_SET_EVENT_MASK2: | |||
| rc = ble_ll_hci_cb_set_event_mask2(cmdbuf, len); | |||
| break; | |||
| #if MYNEWT_VAL(BLE_LL_CFG_FEAT_LE_PING) | |||
| #if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_ENHANCED_CONN_UPDATE) && \ | |||
There was a problem hiding this comment.
this is not related to le ping so whatever it fixes, the problem is somewhere else
There was a problem hiding this comment.
right, I think I misread ifs. I think it should be only for connection. So
#if (MYNEWT_VAL(BLE_LL_ROLE_PERIPHERAL) || MYNEWT_VAL(BLE_LL_ROLE_CENTRAL)) \
&& MYNEWT_VAL(BLE_LL_CFG_FEAT_LE_PING)
instead
KKopyscinski
force-pushed
the
iso_compile_fix
branch
from
daf259a
to
c0a217a
Compare
This fixes build of ISO when only Brodacster is enabled. `ble_phy_ccm_isr` is used ony when BLE_LL_CFG_FEAT_LE_ENCRYPTION (in ble_phy_init) BLE_LL_CFG_FEAT_LE_ENCRYPTION should be enabled when ISO is used, even connection-less ble_ll_conn_hci_rd_auth_pyld_tmo and ble_ll_conn_hci_wr_auth_pyld_tmo are built only with BLE_LL_CFG_FEAT_LL_ENHANCED_CONN_UPDATE enabled
KKopyscinski
force-pushed
the
iso_compile_fix
branch
from
c0a217a
to
8f64098
Compare
|
@andrzej-kaczmarek Waiting for review |
andrzej-kaczmarek
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.