Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

host/gap: fix typo in GAP event macro #1680

Merged
merged 1 commit into from
Jan 29, 2024
Merged

host/gap: fix typo in GAP event macro #1680

merged 1 commit into from
Jan 29, 2024

Conversation

wpiet
Copy link
Contributor

@wpiet wpiet commented Jan 25, 2024

Corrects spelling in BLE_GAP_EVENT_PAIRING_COMPLETE

sjanc
sjanc requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@sjanc sjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately this is part of public API so we need to keep this backward compatible
so please add
#define BLE_GAP_EVENT_PARING_COMPLETE BLE_GAP_EVENT_PAIRING_COMPLETE
with a comment that PARING is deprecated

sjanc
sjanc reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@sjanc sjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok but please also update apps (afair it is used only in bttester)

@wpiet
host/gap: fix typo in GAP event macro
95cd6be 
Corrects spelling in BLE_GAP_EVENT_PAIRING_COMPLETE
@sjanc sjanc merged commit 572e5fb into apache:master Jan 29, 2024
16 checks passed
@wpiet wpiet deleted the gap-typo branch January 29, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanc sjanc sjanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpiet @sjanc